Skip to content

Fix indentation in XmlTextWriter example #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix indentation in XmlTextWriter example #4168

merged 1 commit into from
Apr 29, 2020

Conversation

krwq
Copy link
Member

@krwq krwq commented Apr 27, 2020

I guess this is a bit of OCD on my side since this type is not recommended for usage

@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 27, 2020
carlossanlop
carlossanlop approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suspect the indentation was added to try to represent the actual xml output.

@carlossanlop carlossanlop merged commit 34c0f5c into master Apr 29, 2020
@carlossanlop carlossanlop deleted the krwq-patch-1 branch April 29, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@krwq @carlossanlop @dotnet-bot